Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell autocompletions #46

Merged
merged 4 commits into from
Sep 13, 2018
Merged

Add shell autocompletions #46

merged 4 commits into from
Sep 13, 2018

Conversation

kke
Copy link
Contributor

@kke kke commented Sep 11, 2018

Shell autocompletions

  • bash-completion.sh completion config
  • mortar install-completions [--remove] subcommand that tries to automatically [un]install to known default locations
  • gem post-install message and README update

@kke kke added the enhancement New feature or request label Sep 11, 2018
@jnummelin
Copy link
Contributor

Maybe add also instructions how users can get it to work?

@kke
Copy link
Contributor Author

kke commented Sep 12, 2018

It would be possible to write a lib/rubygems_plugin.rb that would get installed when using rake install (which nobody does) and/or a Makefile that would do it.

Or spec.post_install_message = "To install bash-completions, etcetc"

Also maybe we should make a brew formula.

@kke
Copy link
Contributor Author

kke commented Sep 12, 2018

I wrote an installer. I put it in lib/mortar/bash_completion_installer.rb that gets required from bin/mortar if you use mortar install-completions.

Of course it could be a regular subcommand or just instructions how to install manually.

@jnummelin
Copy link
Contributor

I'd rather see it as a regular sub-command.

@jnummelin jnummelin added this to the 0.2.0 milestone Sep 13, 2018
@jnummelin jnummelin merged commit 393c48d into master Sep 13, 2018
@jnummelin jnummelin mentioned this pull request Sep 14, 2018
@jakolehm jakolehm deleted the feature/completion branch March 12, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants