Allow to inject custom labels via --label option #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnummelin should custom labels be also configurable via shot.yml? |
Definitely yes. |
|
@jnummelin PTAL |
|
@kke @jnummelin PTAL |
kke
reviewed
May 3, 2019
| @@ -10,25 +10,46 @@ def self.load(path) | |||
| raise ConfigError, "Failed to load config, check config file syntax" unless cfg.is_a? Hash | |||
| raise ConfigError, "Failed to load config, overlays needs to be an array" if cfg.key?('overlays') && !cfg['overlays'].is_a?(Array) | |||
|
|
|||
| new(variables: cfg['variables'] || {}, overlays: cfg['overlays'] || []) | |||
| if cfg.key?('labels') | |||
| raise ConfigError, "Failed to load config, labels needs to be a hash" if !cfg['labels'].is_a?(Hash) | |||
There was a problem hiding this comment.
Suggested change
| raise ConfigError, "Failed to load config, labels needs to be a hash" if !cfg['labels'].is_a?(Hash) | |
| raise ConfigError, "Failed to load config, labels needs to be a hash" unless cfg['labels'].is_a?(Hash) |
Minor nitpick
kke
reviewed
May 3, 2019
| new(variables: cfg['variables'] || {}, overlays: cfg['overlays'] || []) | ||
| if cfg.key?('labels') | ||
| raise ConfigError, "Failed to load config, labels needs to be a hash" if !cfg['labels'].is_a?(Hash) | ||
| raise ConfigError, "Failed to load config, label values need to be strings" if cfg['labels'].values.any? { |value| !value.is_a?(String) } |
There was a problem hiding this comment.
Suggested change
| raise ConfigError, "Failed to load config, label values need to be strings" if cfg['labels'].values.any? { |value| !value.is_a?(String) } | |
| raise ConfigError, "Failed to load config, label values need to be strings" unless cfg['labels'].values.all? { |value| value.is_a?(String) } |
Minor nitpick
kke
reviewed
May 3, 2019
| # @param other [Hash] | ||
| # @return [RecursiveOpenStruct] | ||
| def labels(other = {}) | ||
| hash = @labels.dup |
There was a problem hiding this comment.
Minor nitpick:
dup + merge! could just be @labels.merge(other)
kke
approved these changes
May 3, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels
It's possible to set global labels for all resources in a shot via options or configuration file.
Labels via options
Use
mortar --label foo=bar my-app resourceto set label to all resources in a shot.Labels via configuration file