-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to inject custom labels via --label option #91
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5faee25
allow to inject custom labels via --label option
jakolehm df83c9f
Merge branch 'master' of github.com:kontena/mortar
jakolehm 846f59b
Merge branch 'master' of github.com:kontena/mortar
jakolehm 8da46f1
Merge branch 'master' of github.com:kontena/mortar
jakolehm aa1ef76
allow to set labels via config
jakolehm 95c117f
docs
jakolehm 6479e6d
rubocop
jakolehm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,25 +10,46 @@ def self.load(path) | |||||
raise ConfigError, "Failed to load config, check config file syntax" unless cfg.is_a? Hash | ||||||
raise ConfigError, "Failed to load config, overlays needs to be an array" if cfg.key?('overlays') && !cfg['overlays'].is_a?(Array) | ||||||
|
||||||
new(variables: cfg['variables'] || {}, overlays: cfg['overlays'] || []) | ||||||
if cfg.key?('labels') | ||||||
raise ConfigError, "Failed to load config, labels needs to be a hash" if !cfg['labels'].is_a?(Hash) | ||||||
raise ConfigError, "Failed to load config, label values need to be strings" if cfg['labels'].values.any? { |value| !value.is_a?(String) } | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Minor nitpick |
||||||
end | ||||||
|
||||||
new( | ||||||
variables: cfg['variables'] || {}, | ||||||
overlays: cfg['overlays'] || [], | ||||||
labels: cfg['labels'] || {} | ||||||
) | ||||||
end | ||||||
|
||||||
def initialize(variables: {}, overlays: []) | ||||||
def initialize(variables: {}, overlays: [], labels: {}) | ||||||
@variables = variables | ||||||
@overlays = overlays | ||||||
@labels = labels | ||||||
end | ||||||
|
||||||
# @param other [Hash] | ||||||
# @return [RecursiveOpenStruct] | ||||||
def variables(other = {}) | ||||||
hash = @variables.dup | ||||||
hash.deep_merge!(other) | ||||||
RecursiveOpenStruct.new(hash, recurse_over_arrays: true) | ||||||
end | ||||||
|
||||||
# @param other [Array<Object>] | ||||||
# @return [Array<Object>] | ||||||
def overlays(other = []) | ||||||
return @overlays unless other | ||||||
|
||||||
(@overlays + other).uniq.compact | ||||||
end | ||||||
|
||||||
# @param other [Hash] | ||||||
# @return [RecursiveOpenStruct] | ||||||
def labels(other = {}) | ||||||
hash = @labels.dup | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor nitpick:
|
||||||
hash.merge!(other) | ||||||
RecursiveOpenStruct.new(hash) | ||||||
end | ||||||
end | ||||||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
labels: | ||
foo: bar |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
labels: | ||
- foo=bar |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick