cert-manager: optional webhook #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakolehm
changed the title
jakolehm
commented
Jun 18, 2019
| @@ -26,7 +26,7 @@ pharos license assign --help || exit $? | |||
| pharos license inspect --help || exit $? | |||
|
|
|||
| # Test cluster bootstrapping | |||
| timeout 600 pharos up -y -c e2e/digitalocean/cluster.yml --tf-json e2e/digitalocean/tf.json || exit $? | |||
| timeout 700 pharos up -y -c e2e/digitalocean/cluster.yml --tf-json e2e/digitalocean/tf.json || exit $? | |||
There was a problem hiding this comment.
Had to raise timeout limit, it was too close.
| @@ -75,8 +75,8 @@ ssh_userhost="root@${pharos_worker_host}" | |||
| scp -o StrictHostKeyChecking=no -i "${ssh_key}" pharos-cluster*.gem "${ssh_userhost}:" | |||
|
|
|||
| ssh -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -i "${ssh_key}" "${ssh_userhost}" -- "sudo bash -c '\ | |||
| export http_proxy=http://10.133.37.156:8888 HTTP_PROXY=http://10.133.37.156:8888 https_proxy=http://10.133.37.156:8888 HTTPS_PROXY=http://10.133.37.156:8888; | |||
| apt-get update && apt-get -y install ruby build-essential ruby-dev && \ | |||
| export http_proxy=http://10.133.37.156:8888 HTTP_PROXY=http://10.133.37.156:8888 https_proxy=http://10.133.37.156:8888 HTTPS_PROXY=http://10.133.37.156:8888 DEBIAN_FRONTEND=noninteractive; | |||
There was a problem hiding this comment.
Had to fix this because libssl upgrade prompted something.
e2e/drone_setup.sh
Outdated
| @@ -10,15 +10,22 @@ fi | |||
| cd e2e/digitalocean | |||
| terraform init | |||
|
|
|||
| until terraform apply -auto-approve -var "cluster_name=${DRONE_BUILD_NUMBER}-do" -var "image=$1" | |||
| WORKER_UP=${WORKER_UP:-false} | |||
| if [ "${WORKER_UP}" = "true" ]; then | |||
There was a problem hiding this comment.
Reason for this: we should only provision extra machine if we test "worker up".
e2e/drone_setup.sh
Outdated
| do | ||
| echo "Apply failed... trying again in 5s" | ||
| sleep 5 | ||
| done | ||
|
|
||
| terraform output -json > tf.json | ||
|
|
||
| if [ "${WORKER_UP:-false}" = "up" ]; then | ||
| if [ "${WORKER_UP}" = "true" ]; then |
There was a problem hiding this comment.
We didn't really test "worker up" at all..
kke
reviewed
Jun 18, 2019
kke
reviewed
Jun 18, 2019
kke
approved these changes
Jun 18, 2019
Co-Authored-By: Kimmo Lehto <kimmo.lehto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webhook makes initial cluster deployment very slow.. this PR allows to disable it.