-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/del 2757 languages in sdk #256
Merged
petrsvihlik
merged 9 commits into
kontent-ai:master
from
Sevitas:feature/DEL-2757_languages_in_sdk
Jan 18, 2021
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0787887
del-2757 introduce GetLanguagesAsync method in delivery client
kentico-martins2 bc86e9b
del-2757 tests for languages endpoint in DeliveryClient
kentico-martins2 d6bc006
del-2757 tests for caching
kentico-martins2 128fb41
del-2757 introduce languages in DeliveryClientExtesions
kentico-martins2 944adc5
del-2757 introduce languages in DeliveryObservableProxy
kentico-martins2 9cc5693
del-2757 fix typo
kentico-martins2 7993d8e
Merge branch 'master' into feature/DEL-2757_languages_in_sdk
petrsvihlik f86476f
DEL-2757 after review changes
Sevitas 5d8df7d
Merge branch 'feature/DEL-2757_languages_in_sdk' of github.com:Sevita…
Sevitas File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
Kentico.Kontent.Delivery.Abstractions/Languages/IDeliveryLanguageListingResponse.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
using System.Collections.Generic; | ||
|
||
namespace Kentico.Kontent.Delivery.Abstractions | ||
{ | ||
/// <summary> | ||
/// Represents a response from Kentico Kontent Delivery API that contains a list of languages. | ||
/// </summary> | ||
public interface IDeliveryLanguageListingResponse : IResponse, IPageable | ||
{ | ||
/// <summary> | ||
/// Gets a read-only list of languages. | ||
/// </summary> | ||
IList<ILanguage> Languages { get; } | ||
} | ||
} |
13 changes: 13 additions & 0 deletions
13
Kentico.Kontent.Delivery.Abstractions/Languages/ILanguage.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
namespace Kentico.Kontent.Delivery.Abstractions | ||
{ | ||
/// <summary> | ||
/// Represents a language. | ||
/// </summary> | ||
public interface ILanguage | ||
{ | ||
/// <summary> | ||
/// Gets the system attributes of the language. | ||
/// </summary> | ||
ILanguageSystemAttributes System { get; } | ||
} | ||
} |
9 changes: 9 additions & 0 deletions
9
Kentico.Kontent.Delivery.Abstractions/Languages/ILanguageSystemAttributes.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
namespace Kentico.Kontent.Delivery.Abstractions | ||
{ | ||
/// <summary> | ||
/// Represents system attributes of a language. | ||
/// </summary> | ||
public interface ILanguageSystemAttributes : ISystemBaseAttributes | ||
{ | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,28 +3,13 @@ | |
namespace Kentico.Kontent.Delivery.Abstractions | ||
{ | ||
/// <summary> | ||
/// Represents system attributes of any object in Kentico Kontent. | ||
/// Represents system attributes of ContentItem, ContentType and Taxonomy objects in Kentico Kontent. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this abstraction should know nothing about the objects that implement it. therefore even this comment seems to be irrelevant. |
||
/// </summary> | ||
public interface ISystemAttributes | ||
public interface ISystemAttributes : ISystemBaseAttributes | ||
{ | ||
/// <summary> | ||
/// Gets the codename of the object. | ||
/// </summary> | ||
string Codename { get; } | ||
|
||
/// <summary> | ||
/// Gets the identifier of the object. | ||
/// </summary> | ||
string Id { get; } | ||
|
||
/// <summary> | ||
/// Gets the time the object was last modified. | ||
/// </summary> | ||
DateTime LastModified { get; } | ||
petrsvihlik marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/// <summary> | ||
/// Gets the name of the object. | ||
/// </summary> | ||
string Name { get; } | ||
} | ||
} |
23 changes: 23 additions & 0 deletions
23
Kentico.Kontent.Delivery.Abstractions/SharedModels/ISystemBaseAttributes.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
namespace Kentico.Kontent.Delivery.Abstractions | ||
{ | ||
/// <summary> | ||
/// Represents system base attributes of any object in Kentico Kontent. | ||
/// </summary> | ||
public interface ISystemBaseAttributes | ||
{ | ||
/// <summary> | ||
/// Gets the codename of the object. | ||
/// </summary> | ||
string Codename { get; } | ||
|
||
/// <summary> | ||
/// Gets the identifier of the object. | ||
/// </summary> | ||
string Id { get; } | ||
|
||
/// <summary> | ||
/// Gets the name of the object. | ||
/// </summary> | ||
string Name { get; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we be a bit more specific? Something like "returns all active languages assigned to a given project and matching the optional filtering parameters."...