-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/del 2757 languages in sdk #256
Feature/del 2757 languages in sdk #256
Conversation
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
- Coverage 80.67% 80.63% -0.05%
==========================================
Files 108 111 +3
Lines 1573 1611 +38
Branches 452 465 +13
==========================================
+ Hits 1269 1299 +30
Misses 88 88
- Partials 216 224 +8
Continue to review full report at Codecov.
|
@@ -3,28 +3,13 @@ | |||
namespace Kentico.Kontent.Delivery.Abstractions | |||
{ | |||
/// <summary> | |||
/// Represents system attributes of any object in Kentico Kontent. | |||
/// Represents system attributes of ContentItem, ContentType and Taxonomy objects in Kentico Kontent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this abstraction should know nothing about the objects that implement it. therefore even this comment seems to be irrelevant.
@@ -65,5 +65,16 @@ public static Task<IDeliveryTaxonomyListingResponse> GetTaxonomiesAsync(this IDe | |||
{ | |||
return client.GetTaxonomiesAsync(parameters); | |||
} | |||
|
|||
/// <summary> | |||
/// Returns languages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we be a bit more specific? Something like "returns all active languages assigned to a given project and matching the optional filtering parameters."...
@@ -235,6 +236,21 @@ public async Task<IDeliveryTaxonomyListingResponse> GetTaxonomiesAsync(IEnumerab | |||
return new DeliveryTaxonomyListingResponse(response, taxonomies.ToList<ITaxonomyGroup>(), pagination); | |||
} | |||
|
|||
/// <summary> | |||
/// Returns languages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, a better comment here would be appreciated.
…s/kontent-delivery-sdk-net into feature/DEL-2757_languages_in_sdk
tested with:
|
Motivation
Introducing new listing endpoint for Languages in Delivery API and adding support for it in SDK
Checklist
How to test
Check that method returns only active languages for project