Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental - filtering items based on query string filter #193

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Experimental - filtering items based on query string filter #193

merged 6 commits into from
Oct 22, 2021

Conversation

Simply007
Copy link
Contributor

Motivation

Related to #191

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Simply007 Simply007 self-assigned this Sep 6, 2021
@Simply007
Copy link
Contributor Author

The tests are failing because the default behavior has changed for v 1.1.12 of gatsby-plugin-image - https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-image/CHANGELOG.md#120-2021-03-30

@Simply007 Simply007 marked this pull request as ready for review October 22, 2021 10:20
@Simply007 Simply007 requested a review from a team October 22, 2021 10:20
@Simply007 Simply007 merged commit 648e82d into master Oct 22, 2021
@Simply007 Simply007 deleted the feature/191 branch October 22, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Simply007 Simply007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Simply007