Localize Sample App #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- able to switch culture via ugly button - localized some of the hardcoded content into resx file - able to fetch items based on culture from Delivery API
- added language constraint - pushed hardcoded strings into resource file - modified design of language switcher based on EMS dancing goat
|
in general, the code lgtm however, it doesn't work because there is no localized data in the sample project (this needs to be fixed before merging this PR) |
petrsvihlik
suggested changes
Jul 11, 2017
|
|
||
| public Task<DeliveryItemResponse<T>> GetItemAsync<T>(string codename, IEnumerable<IQueryParameter> parameters = null) | ||
| { | ||
| return parameters != null ? _client.GetItemAsync<T>(codename, new[] { new LanguageParameter(_language) }.Concat(parameters)) : |
There was a problem hiding this comment.
Value cannot be null.
Parameter name: second
can be seen on the homepage
--> localized data is missing in the sample project 975bf280-fd91-488c-994c-2f04416e5ee3
There was a problem hiding this comment.
This was caused by missing data in sample project. Should be fixed in next commit
petrsvihlik
approved these changes
Jul 12, 2017
|
some links don't work |
5 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added localization support for sample site.