-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multilingual support #18
Comments
Hi! I'd love to help with this :) Spanish is my first language and I translated if-me.org... msg me! |
Hi @beemtz, Not too long ago, we added localization support to our headless CMS - Kentico Cloud. We demonstrated the functionality in the sample app for .NET and we'd like to do the same for this sample react app. So the idea here is to add a language dropdown to the web site which would switch the context between English and Spanish culture. Behind the scenes, it will basically be adding of a language parameter to the calls made by the delivery client. This is well described here: https://github.com/Enngage/KenticoCloudDeliveryTypeScriptSDK#getting-localized-items Texts that are not being retrieved from the Kentico Delivery API (=are hardcoded...eg. buttons) should be translated as well. We should use a standardized approach to do this...e.g. https://stackoverflow.com/questions/14358817/best-practice-for-localization-and-globalization-of-strings-and-labels There is a bonus part as well: some of the texts that come from the Kentico Delivery API (probably most of them) are not translated to Spanish. It'd be great to have someone who speaks Spanish translate them. :) Let me know if you're interested in helping out here as well. Localization-related changes in the .NET app (for inspiration):
|
Hello!
I’m mostly interested in the translation part per se. I’m still too scared of messing with repos on my own. :S
B*
|
Hello!
I… tried…
Do let me know if I need to make adjustments in my approach.
Thanks!
B
… On Oct 24, 2017, at 3:26 AM, Petr Švihlík ***@***.***> wrote:
hey @beemtz <https://github.com/beemtz> , sorry for the delay. i needed to discuss the approach with my colleagues. i've created a separate issue for the translations themselves. feel free to accept the invitation to this project and assign the issue (#20 <#20>) to yourself.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVmnvrIKmyuSOajlyRmGjtvf5Y6FXQh4ks5svZ8ngaJpZM4P6rmt>.
|
@JanLenoch could you please give @beemtz some guidance in #20 ? thx |
Started with upgrading react router to v4 |
Submitted a pull request with, let's say extendable support of multiple language with Spanish translation |
Similarly to kontent-ai/sample-app-net#19, add a Spanish translation of the site.
The text was updated successfully, but these errors were encountered: