Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multilingual support #18

Closed
5 tasks done
petrsvihlik opened this issue Oct 16, 2017 · 8 comments
Closed
5 tasks done

Add multilingual support #18

petrsvihlik opened this issue Oct 16, 2017 · 8 comments

Comments

@petrsvihlik
Copy link
Contributor

petrsvihlik commented Oct 16, 2017

Similarly to kontent-ai/sample-app-net#19, add a Spanish translation of the site.

  • Add a language switch
  • Add appropriate routing mechanism using router-react, or router-react-redux (or a similar standardized technology)
  • Add a globalization (resource) strings support (again, choose a common approach)
  • Translate globalization strings
  • Translate texts in the KC Sample Project (separate issue: Translate Dancing Goat to Spanish #20)
@beemtz
Copy link
Contributor

beemtz commented Oct 22, 2017

Hi! I'd love to help with this :) Spanish is my first language and I translated if-me.org... msg me!

@petrsvihlik
Copy link
Contributor Author

Hi @beemtz,
Thanks for your interest!

Not too long ago, we added localization support to our headless CMS - Kentico Cloud.

We demonstrated the functionality in the sample app for .NET and we'd like to do the same for this sample react app.

So the idea here is to add a language dropdown to the web site which would switch the context between English and Spanish culture. Behind the scenes, it will basically be adding of a language parameter to the calls made by the delivery client. This is well described here: https://github.com/Enngage/KenticoCloudDeliveryTypeScriptSDK#getting-localized-items

Texts that are not being retrieved from the Kentico Delivery API (=are hardcoded...eg. buttons) should be translated as well. We should use a standardized approach to do this...e.g. https://stackoverflow.com/questions/14358817/best-practice-for-localization-and-globalization-of-strings-and-labels

There is a bonus part as well: some of the texts that come from the Kentico Delivery API (probably most of them) are not translated to Spanish. It'd be great to have someone who speaks Spanish translate them. :) Let me know if you're interested in helping out here as well.

Localization-related changes in the .NET app (for inspiration):

@beemtz
Copy link
Contributor

beemtz commented Oct 22, 2017 via email

@petrsvihlik
Copy link
Contributor Author

hey @beemtz , sorry for the delay. i needed to discuss the approach with my colleagues. i've created a separate issue for the translations themselves. feel free to accept the invitation to this project and assign the issue (#20) to yourself.

@beemtz
Copy link
Contributor

beemtz commented Oct 24, 2017 via email

@petrsvihlik
Copy link
Contributor Author

petrsvihlik commented Oct 24, 2017

@JanLenoch could you please give @beemtz some guidance in #20 ? thx

@petrsvihlik petrsvihlik assigned beemtz and unassigned beemtz Oct 24, 2017
@Simply007 Simply007 self-assigned this Nov 16, 2017
@Simply007
Copy link
Contributor

Started with upgrading react router to v4
https://github.com/Kentico/cloud-sample-app-react/tree/multilingual-support

@Simply007
Copy link
Contributor

Submitted a pull request with, let's say extendable support of multiple language with Spanish translation
#64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants