Added footer react component #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply007
suggested changes
Jan 17, 2018
| </head> | ||
|
|
||
| <body> | ||
| <div class="page-wrap" id="root"></div> | ||
| <div class="footer-wrapper"> |
There was a problem hiding this comment.
Please remove html that is commented out.
| @@ -0,0 +1,97 @@ | |||
| import React, { Component } from 'react'; | |||
|
|
|||
| class Footer extends Component { | |||
There was a problem hiding this comment.
Please do not use inline styles.
use className instead of class attribute to ensure proper stylink.
Hint:
It is required also to remove one line in index.css to ensure width of the footer.:
|
I have made some changes to be able to merge automatically, because after merging pull request on multilingual support (#64) automatic merge was not possible. Please pull the new version before making requested changes. |
|
Hello @prakharcipher - we have already received a complete pull request (#70). If you want to contribute the one of out repositories, just leave me a message and we can find something interesting for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#65