-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footer Component #70
Footer Component #70
Conversation
@jmb521 Thank you! This is exactly what we wanted. I went through the the changes and everything looks fine. According to multilingual support:
Hint: Some more info: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the the changes and everything looks fine.
If you have any questions according the translation - feel free to ask :-)
…h calls to props.t so that the correct language shows up on the footer
I made the changes. Not sure what I need to do now, if anything. |
Fixes #65 |
Thank you, it is awesome to get as precise pull request 👍 Everything you have done is exactly, what was required in this task. Thank you very much. If you are looking for another issue to grab, it would be the best to remove two unnecessary fields in the Article model (/Models/Article) described in issue comment: We have also defined a content snippet in the brewer content type (first part of the issue) (https://deliver.kenticocloud.com/975bf280-fd91-488c-994c-2f04416e5ee3/items/aeropress) but we need to decide, how do we want do use them on the sample app. It will be probably something similar as in our .net sample app https://github.com/Kentico/cloud-sample-app-net. So if you are interested, just let me know and i will prepare the description. Thanks again :-) |
I attempted to complete the language changes, however I was unsuccessful.