Migrate to typescript sdk #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t has caused error while building final package, because it contained empty url() value
|
@ChristopherJennings feel free to do the review if you get to it sooner than me :) thx |
…o_use_taxonomies Feature/del 1193 update filters to use taxonomies
|
Unfortunately, there are some extra steps required because of #11 .
|
…t has caused error while building final package, because it contained empty url() value
|
thanks @Simply007 ...Chris or I will have a look at it soon |
|
Reviewed the code changes nothing stood out as problematic. All previous functionality appears to be preserved and working. Thanks for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal link:
https://kentico.atlassian.net/browse/CM-8367
rewritten Client,js to Delivery client
rewritten Stores to use this client
removed closure optimization that stored already created promises, because it was never used - confirmed with jiris
removed section for media gallery - it is not used and caused error when building to production package (contained empty url as a value)