Change deprecated componentWillReceiveProps to componentWillUpdate be… #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause of side effects
Simply007
suggested changes
Oct 1, 2018
There was a problem hiding this comment.
Hello @Karl-EdwardFPJeanMehu,
unfortunately, method componentWillUpdate is also deprecated and will be removed in React v17.
More info:
I would go by getDerivedStateFromProps as i proposed in #97.
- Just make sure that all the components are updated properly - mainly when switching between languages and loader (introduced in added basic loading spinner to sample app #93) works as before the change.
|
You're right! Please review corrections #105 |
|
Duplicate of #105. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #97 All occurrences included side effects so replace with componentWillUpdate.