Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the projects dynamic parts #60

Closed
rwaDept opened this issue Jun 8, 2020 · 2 comments · Fixed by #61
Closed

Update the projects dynamic parts #60

rwaDept opened this issue Jun 8, 2020 · 2 comments · Fixed by #61
Assignees
Labels
enhancement New feature or request groomed The issue has been groomed and should be in a good shape.

Comments

@rwaDept
Copy link

rwaDept commented Jun 8, 2020

Today I setup this sample project for the first time. I'm new to this product and would use this sample project as a way to find my way around Kentiko Kontent / SaaS. I used the documentation page as a guide (https://docs.kontent.ai/tutorials/develop-apps/get-started/run-sample-app?tech=javascript#a-making-changes-to-your-project).

After the successful first run I of course go and try to change an item in the CMS in order to see that change being reflected on my sample site. Unfortunately I was disappointed not to see this change happen. After a talk with your excellent in app chat and digging around a little myself I come to the realisation that not every part of this sample project is being loaded dynamically from the CMS.

I understand the need to show that you can combine the dynamic pages with static ones. However since it's main purpose is showing off the connection with Kentiko Kontent I'd at least expect the home page (the first page you see) to be dynamic. Personally I'd create a separate section of the site to show off the static parts. But barring that, it would have been nice to know at least that not all parts are actually dynamic, and which parts are.

So in short; at least add some documentation somewhere (where it can't be missed) stating that not all content in the sample project is being loaded dynamically, where to find that static content in the code and additionally maybe state which content parts are dynamic and which are not.

Lastly, maybe move the entire static part to its own section. Though as long as it's clear where the content comes from this is less of an issue. I also understand the need for a page with a mixture of dynamic / non-dynamic content.

@Simply007
Copy link
Contributor

Simply007 commented Jun 17, 2020

Hello @rwaDept,

the first step would be to point people how to distinguish the data loaded from Kontent and ones loaded from JSONs.

I think the solution could look like:

  • All data loaded from Kentico Kontent are using Stores as for examples "Latest Articles" section (component here) on Home Page
  • The data provided from Localization are using vue-i18n plugin, so every call in components using $t('KEYWORD') in components is loading data from these JSONs as for example "Banner" section" (component here)

@rwaDept
Copy link
Author

rwaDept commented Jun 17, 2020

Hello @Simply007,

Yes that's a good first step, adding that to the readme here on GitHub. Though, as long as the dynamic and JSON content is mixed ideally I'd say it's a good idea to also show that on the sample site itself (maybe a notification inside the content itself?). Not everyone will open the code before checking the connection and thus might not see the localisation parts.

@Simply007 Simply007 mentioned this issue Jun 26, 2020
5 tasks
@Simply007 Simply007 self-assigned this Jun 26, 2020
@Simply007 Simply007 added enhancement New feature or request groomed The issue has been groomed and should be in a good shape. labels Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request groomed The issue has been groomed and should be in a good shape.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants