Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

[Backport] Filter VMware VM templates out of the UI (#583) #584

Merged
1 commit merged into from
May 6, 2021

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented May 6, 2021

Backports #583

@mturley mturley requested a review from a team May 6, 2021 19:58
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@konveyor-preview-bot
Copy link

🚀 Deployed Preview: http://konveyor-forklift-ui-pr-584-preview.surge.sh

Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #584 (90a6a1e) into release-v2.0.0 (cb899a5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-v2.0.0     #584      +/-   ##
==================================================
+ Coverage           59.94%   59.96%   +0.01%     
==================================================
  Files                 137      137              
  Lines                4394     4396       +2     
  Branches             1202     1203       +1     
==================================================
+ Hits                 2634     2636       +2     
  Misses               1727     1727              
  Partials               33       33              
Impacted Files Coverage Δ
src/app/queries/mocks/tree.mock.ts 100.00% <ø> (ø)
src/app/queries/mocks/vms.mock.ts 100.00% <100.00%> (ø)
src/app/queries/vms.ts 91.66% <100.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb899a5...90a6a1e. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 29e3ef1 into kubev2v:release-v2.0.0 May 6, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants