-
Notifications
You must be signed in to change notification settings - Fork 27
fix(cleanup): fix skip to content link page refresh issue #616
Conversation
Ah, Also I see you're lacking maintainer rights, I'll fix that! |
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-616-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome onboard!
LGTM.
@seanforyou23 looks like this is failing CI because of eslint errors. I forgot to mention we're using Prettier and enforcing its formatting using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the lint errors!
update broken link in readme ensure loading spinner has an accessible name update tests
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## main #616 +/- ##
==========================================
- Coverage 58.74% 58.71% -0.04%
==========================================
Files 143 143
Lines 4727 4735 +8
Branches 1298 1299 +1
==========================================
+ Hits 2777 2780 +3
- Misses 1913 1918 +5
Partials 37 37
Continue to review full report at Codecov.
|
This PR is mostly just some small housekeeping items. The link in quickstart for the example json content was out of date, I updated and also made it a relative path so it works as expected on forks.
I'm unsure what .env.example is supposed to point to?
I also noticed when selecting the SkipToContent link the whole page refreshes, this should be fixed now.
Lastly, the spinner just needed an accessible name