Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Use blank name and namespace for ephemeral plan/mappings #627

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Use blank name and namespace for ephemeral plan/mappings #627

merged 2 commits into from
Jun 9, 2021

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jun 7, 2021

#620 follow-up

@gildub gildub requested a review from a team June 7, 2021 10:27
@konveyor-preview-bot
Copy link

🚀 Deployed Preview: http://konveyor-forklift-ui-pr-627-preview.surge.sh

Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #627 (0a2eeaf) into main (f6a508e) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 0a2eeaf differs from pull request most recent head a611d85. Consider uploading reports for the commit a611d85 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   59.29%   59.25%   -0.05%     
==========================================
  Files         144      144              
  Lines        4771     4766       -5     
  Branches     1313     1309       -4     
==========================================
- Hits         2829     2824       -5     
  Misses       1904     1904              
  Partials       38       38              
Impacted Files Coverage Δ
src/app/Plans/components/Wizard/Review.tsx 96.29% <ø> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40846c...a611d85. Read the comment docs.

@mturley
Copy link
Collaborator

mturley commented Jun 8, 2021

@gildub do you mind also removing the unused imports in Review.tsx?

@mturley
Copy link
Collaborator

mturley commented Jun 9, 2021

This has a minor merge conflict now after merging #597. sorry!

@gildub
Copy link
Contributor Author

gildub commented Jun 9, 2021

@mturley, please review after rebase.

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mturley mturley merged commit cd01434 into kubev2v:main Jun 9, 2021
@gildub gildub deleted the blank-names-for-display branch June 10, 2021 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants