Upload binary analysis test (#101)

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
konveyor · Mar 19, 2024 · f2eaffd · f2eaffd
1 parent b70d8e0
commit f2eaffd
Show file tree

Hide file tree

Showing 8 changed files with 106 additions and 2 deletions.
diff --git a/analysis/analysis_test.go b/analysis/analysis_test.go
@@ -5,6 +5,8 @@ import (
 	"crypto/cipher"
 	"crypto/sha256"
 	"encoding/hex"
+	"io"
+	"net/http"
 	"os"
 	"sort"
 	"strings"
@@ -116,9 +118,20 @@ func TestApplicationAnalysis(t *testing.T) {
 			if tc.Scope != nil {
 				taskData.Scope = *tc.Scope
 			}
+
+			taskData.Mode.Artifact = tc.Artifact
 			tc.Task.Data = taskData
 			assert.Should(t, RichClient.Task.Create(&tc.Task))
 
+			if tc.Artifact != "" {
+				// Upload binary file into the bucket
+				bucketContent := RichClient.Bucket.Content(tc.Task.Bucket.ID)
+				bucketContent.Put("data"+tc.Artifact, tc.Artifact)
+			}
+
+			tc.Task.State = "Ready"
+			assert.Should(t, RichClient.Task.Update(&tc.Task))
+
 			// Wait until task finishes
 			var task *api.Task
 			var err error
@@ -328,3 +341,26 @@ func getDefaultToken() string {
 	}
 	return string(decrypted)
 }
+
+// DownloadFile downloads the file, params:
+// 1) name of file to save as
+// 2) URL to download FROM
+func DownloadFile(filePath string, url string) error {
+	// Get the data
+	resp, err := http.Get(url)
+	if err != nil {
+		return err
+	}
+	defer resp.Body.Close()
+
+	// Create the file
+	out, err := os.Create(filePath)
+	if err != nil {
+		return err
+	}
+	defer out.Close()
+
+	// Write the body to file
+	_, err = io.Copy(out, resp.Body)
+	return err
+}
diff --git a/analysis/analyzer_defaults.go b/analysis/analyzer_defaults.go
@@ -6,7 +6,7 @@ import (
 )
 
 var Analyze = api.Task{
-	State: "Ready", // Created / Ready
+	State: "Created", // Created / Ready
 	Data:  defaultAnalyzerData,
 	Addon: "analyzer",
 }

diff --git a/analysis/data/binary/administracion_efectivo.ear b/analysis/data/binary/administracion_efectivo.ear
diff --git a/analysis/pkg.go b/analysis/pkg.go
@@ -46,6 +46,7 @@ type TC struct {
 	Scope    *addon.Scope
 	WithDeps bool
 	Binary bool
+	Artifact string
 	// After-analysis assertions.
 	ReportContent map[string][]string
 	Analysis      api.Analysis

diff --git a/analysis/tc_administracion_efectivo_upload_binary.go b/analysis/tc_administracion_efectivo_upload_binary.go
@@ -0,0 +1,63 @@
+package analysis
+
+import (
+	"github.com/konveyor/go-konveyor-tests/data"
+	"github.com/konveyor/go-konveyor-tests/hack/addon"
+	"github.com/konveyor/tackle2-hub/api"
+)
+
+var AdministracionEfectivo = TC{
+	Name:        "administracion-efectivo",
+	Application: data.UploadBinary,
+	Task:        Analyze,
+	Labels: addon.Labels{
+		Included: []string{
+			"konveyor.io/target=cloud-readiness",
+		},
+	},
+	Binary:   true,
+	Artifact: "/binary/administracion_efectivo.ear",
+	Analysis: api.Analysis{
+		Effort: 1591,
+		Issues: []api.Issue{
+			{
+				Category:    "mandatory",
+				Description: "Java native libraries (JNI, JNA)",
+				Effort:      7,
+				RuleSet:     "cloud-readiness",
+				Rule:        "jni-native-code-00000",
+			},
+			{
+				Category:    "mandatory",
+				Description: "File system - Java IO",
+				Effort:      1,
+				RuleSet:     "cloud-readiness",
+				Rule:        "local-storage-00001",
+			},
+			{
+				Category:    "mandatory",
+				Description: "File system - java.net.URL/URI",
+				Effort:      1,
+				RuleSet:     "cloud-readiness",
+				Rule:        "local-storage-00002",
+			},
+		},
+	},
+	AnalysisTags: []api.Tag{
+		{Name: "Servlet", Category: api.Ref{Name: "HTTP"}},
+		{Name: "EAR Deployment", Category: api.Ref{Name: "Other"}},
+		{Name: "JNI", Category: api.Ref{Name: "Other"}},
+		{Name: "Mail", Category: api.Ref{Name: "Other"}},
+		{Name: "Spring Scheduled", Category: api.Ref{Name: "Processing"}},
+		{Name: "Mail", Category: api.Ref{Name: "Connect"}},
+		{Name: "Servlet", Category: api.Ref{Name: "Connect"}},
+		{Name: "EAR Deployment", Category: api.Ref{Name: "Connect"}},
+		{Name: "JNI", Category: api.Ref{Name: "Connect"}},
+		{Name: "JNI", Category: api.Ref{Name: "Java EE"}},
+		{Name: "Servlet", Category: api.Ref{Name: "Java EE"}},
+		{Name: "EAR Deployment", Category: api.Ref{Name: "Java EE"}},
+		{Name: "Mail", Category: api.Ref{Name: "Java EE"}},
+		{Name: "Spring Scheduled", Category: api.Ref{Name: "Embedded"}},
+		{Name: "Spring Scheduled", Category: api.Ref{Name: "Execute"}},
+	},
+}
diff --git a/analysis/tc_tackle_testapp_private.go → analysis/tc_tackle_testapp_private_binary.go b/analysis/tc_tackle_testapp_private.go → analysis/tc_tackle_testapp_private_binary.go
diff --git a/analysis/test_cases.go b/analysis/test_cases.go
@@ -5,6 +5,7 @@ package analysis
 var Tier0TestCases = []TC{
 	TackleTestappPublicWithDeps,
 	TackleTestappPublicPackageFilter,
+	AdministracionEfectivo,
 }
 
 // Tier 1 Analysis test cases - should work.

diff --git a/data/application_data.go b/data/application_data.go
@@ -34,5 +34,8 @@ var (
 		},
 		Binary: "io.konveyor.demo:customers-tomcat:0.0.1-SNAPSHOT:war",
 	}
-	ApplicationSamples = []api.Application{Minimal, PathfinderGit, BookServer, TackleTestapp}
+	UploadBinary = api.Application {
+		Name: "upload-binary",
+	}
+	ApplicationSamples = []api.Application{Minimal, PathfinderGit, BookServer, TackleTestapp, UploadBinary}
 )