Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload binary analysis test #101

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

mguetta1
Copy link
Collaborator

@mguetta1 mguetta1 commented Mar 11, 2024

Adding upload binary analysis test

  • Please note that in order to get the Task ID and use it to upload the binary file, the Task resource is created with State: "Created", and once the binary file is uploaded, the task is submitted by updating it with State: "Ready"

  • Skipping Incidents check due to the amount

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice solution with Created/Ready task for artifact upload.

Just thinking about adding AdministracionEfectivo.ear file to this repo, do we know it is an open-source example?

@mguetta1
Copy link
Collaborator Author

Just thinking about adding AdministracionEfectivo.ear file to this repo, do we know it is an open-source example?

Good question. @sshveta can you confirm that please?

@sshveta
Copy link
Collaborator

sshveta commented Mar 12, 2024

AdministracionEfectivo.ear

This file was provided to us by MTR team (phil) for testing .
We have been using it since then .
Let me check witht them on open source thing .

@sshveta
Copy link
Collaborator

sshveta commented Mar 12, 2024

AdministracionEfectivo.ear

Not sure about this @mguetta1 . We can use acmeair-webapp-1.0-SNAPSHOT.war which we are using in tackle tests . Not sure about that one too though.

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1
Copy link
Collaborator Author

@sshveta @aufi I noticed that the file is already in a public repository:
https://github.com/konveyor/tackle-ui-tests/blob/main/cypress/fixtures/administracionEfectivo.ear

I added a function to download it

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@aufi
Copy link
Member

aufi commented Mar 14, 2024

@pranavgaikwad for visibility

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1 mguetta1 merged commit f2eaffd into konveyor:main Mar 19, 2024
3 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
mguetta1 added a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: Maayan Hadasi <60384172+mguetta1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants