-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload binary analysis test #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice solution with Created/Ready task for artifact upload.
Just thinking about adding AdministracionEfectivo.ear
file to this repo, do we know it is an open-source example?
Good question. @sshveta can you confirm that please? |
This file was provided to us by MTR team (phil) for testing . |
Not sure about this @mguetta1 . We can use acmeair-webapp-1.0-SNAPSHOT.war which we are using in tackle tests . Not sure about that one too though. |
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
3f528b8
to
71beb54
Compare
@sshveta @aufi I noticed that the file is already in a public repository: I added a function to download it |
@pranavgaikwad for visibility |
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
Adding upload binary analysis test
Please note that in order to get the Task ID and use it to upload the binary file, the Task resource is created with
State: "Created"
, and once the binary file is uploaded, the task is submitted by updating it withState: "Ready"
Skipping Incidents check due to the amount