Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport - 1.7.2] Bug 2038898: Add valued update check for aws s3/s3 repo type (#1436) #1441

Merged
merged 1 commit into from Jun 8, 2022
Merged

[Backport - 1.7.2] Bug 2038898: Add valued update check for aws s3/s3 repo type (#1436) #1441

merged 1 commit into from Jun 8, 2022

Conversation

rayfordj
Copy link
Contributor

@rayfordj rayfordj commented Jun 8, 2022

  • Add valued update check for aws s3/s3 repo type

  • cleanup

@ibolton336 @rayfordj
Bug 2038898: Add valued update check for aws s3/s3 repo type (migtool…
2c6f2db 
…s#1436)

* Add valued update check for aws s3/s3 repo type

* cleanup
@rayfordj rayfordj requested a review from a team June 8, 2022 20:40
@rayfordj
Copy link
Contributor Author

rayfordj commented Jun 8, 2022

Cherry-pick: #1436

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022
@mturley mturley changed the title Bug 2038898: Add valued update check for aws s3/s3 repo type (#1436) [Backport - 1.7.2] Bug 2038898: Add valued update check for aws s3/s3 repo type (#1436) Jun 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@rayfordj: This pull request references Bugzilla bug 2038898, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2038898: Add valued update check for aws s3/s3 repo type (#1436)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mturley
Copy link
Collaborator

mturley commented Jun 8, 2022

Edited the title to make it easier to distinguish from the main PR.

@mturley mturley merged commit 11ef65a into migtools:release-1.7.2 Jun 8, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mturley, rayfordj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mturley, rayfordj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@rayfordj: All pull requests linked via external trackers have merged:

Bugzilla bug 2038898 has been moved to the MODIFIED state.

In response to this:

[Backport - 1.7.2] Bug 2038898: Add valued update check for aws s3/s3 repo type (#1436)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayfordj rayfordj deleted the bz2038898-1.7.2 branch June 8, 2022 20:45
This was referenced Jun 16, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturley mturley mturley approved these changes

Assignees

@mturley mturley

Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rayfordj @mturley @ibolton336