Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport - 1.7.2] Bug 2062862: Check for errors in promise.all call and allow partial failure (#1435) #1443

Merged
merged 1 commit into from Jun 9, 2022

Conversation

rayfordj
Copy link
Contributor

@rayfordj rayfordj commented Jun 8, 2022

cherry-pick: #1435

  • Check for errors in promise.all call and allow partial failure

  • cleanup

  • cleanup

  • Change from string to undefined to match storage implementation

…ailure (migtools#1435)

* Check for errors in promise.all call and allow partial failure

* cleanup

* cleanup

* Change from string to undefined to match storage implementation
@rayfordj rayfordj requested a review from a team June 8, 2022 21:06
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

@rayfordj: This pull request references Bugzilla bug 2062862, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ssingla@redhat.com), skipping review request.

In response to this:

[Backport - 1.7.2] Bug 2062862: Check for errors in promise.all call and allow partial failure (#1435)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 8, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mturley, rayfordj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley mturley merged commit 7c87240 into migtools:release-1.7.2 Jun 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2022

@rayfordj: All pull requests linked via external trackers have merged:

Bugzilla bug 2062862 has been moved to the MODIFIED state.

In response to this:

[Backport - 1.7.2] Bug 2062862: Check for errors in promise.all call and allow partial failure (#1435)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rayfordj rayfordj deleted the bz2062862-1.7.2 branch June 9, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants