Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport - 1.7.2] Bug 2056962: For non-SCC intra-cluster migrations, don't allow target namespace to equal source namespace (#1439) #1456

Merged
merged 1 commit into from Jun 17, 2022

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Jun 16, 2022

Backports #1439

… namespace to equal source namespace (migtools#1439)

Co-authored-by: Ian Bolton <ibolton@redhat.com>
@mturley mturley requested a review from a team June 16, 2022 17:12
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 16, 2022
@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2022

@mturley: This pull request references Bugzilla bug 2056962, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[Backport - 1.7.2] Bug 2056962: For non-SCC intra-cluster migrations, don't allow target namespace to equal source namespace (#1439)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibolton336, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@openshift-bot: This pull request references Bugzilla bug 2056962, which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xjiang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 17, 2022
@openshift-ci openshift-ci bot merged commit bd4f75c into migtools:release-1.7.2 Jun 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 17, 2022

@mturley: All pull requests linked via external trackers have merged:

Bugzilla bug 2056962 has been moved to the MODIFIED state.

In response to this:

[Backport - 1.7.2] Bug 2056962: For non-SCC intra-cluster migrations, don't allow target namespace to equal source namespace (#1439)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mturley mturley deleted the release-1.7.2-pr1439 branch June 21, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants