Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.7.4] Upgrade webpack-dev-server to v4 and other webpack dependencies to latest (#1414) #1468

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Aug 8, 2022

Backports #1414

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=2110855
https://bugzilla.redhat.com/show_bug.cgi?id=2110856
https://bugzilla.redhat.com/show_bug.cgi?id=2110857
https://bugzilla.redhat.com/show_bug.cgi?id=2110859
https://bugzilla.redhat.com/show_bug.cgi?id=2110860

Note: there were merge conflicts in yarn.lock, which I resolved by reverting to the yarn.lock present on release-1.7.4, then manually pasting the webpack-related package versions from the yarn.lock present on master, then running yarn to resolve the transitive dependencies.

@mturley mturley requested a review from a team August 8, 2022 18:06
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@mturley mturley requested review from rayfordj and removed request for ibolton336 and JaydipGabani August 8, 2022 18:06
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley, rayfordj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e5d989a into migtools:release-1.7.4 Aug 8, 2022
@mturley mturley deleted the release-1.7.4-webpack-dev-server-4 branch August 8, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants