Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic when a port is not specified in an Openshift Route #1087

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

HarikrishnanBalagopal
Copy link
Contributor

No description provided.

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Sep 6, 2023
@HarikrishnanBalagopal HarikrishnanBalagopal linked an issue Sep 6, 2023 that may be closed by this pull request
@ashokponkumar
Copy link
Member

If port is nil, which port are we exposing?

@HarikrishnanBalagopal
Copy link
Contributor Author

HarikrishnanBalagopal commented Sep 6, 2023

If port is nil, which port are we exposing?

https://github.com/openshift/api/blob/8891815aa476232109dccf6c11b8611d209445d9/route/v1/types.go#L135-L138

	// If specified, the port to be used by the router. Most routers will use all
	// endpoints exposed by the service by default - set this value to instruct routers
	// which port to use.
	Port *RoutePort `json:"port,omitempty" protobuf:"bytes,5,opt,name=port"`

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09% 🎉

Comparison is base (6a71835) 14.91% compared to head (7c5da71) 15.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   14.91%   15.00%   +0.09%     
==========================================
  Files          86       86              
  Lines        8188     8135      -53     
==========================================
  Hits         1221     1221              
+ Misses       6648     6595      -53     
  Partials      319      319              
Files Changed Coverage Δ
transformer/kubernetes/apiresource/service.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…like Openshift Routes

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@seshapad seshapad merged commit 89a9d8f into konveyor:main Sep 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: seg fault during version conversion
3 participants