Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug where all yaml files were treated as K8s yamls by the Parameterizer #1162

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

HarikrishnanBalagopal
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal commented Mar 21, 2024

Avoid these errors

ERRO[0001] Unable to parameterize for helm : there is no kind specified in the k8s resource map[resources:[enterprise-app-run-clone-build-push-triggertemplate.yaml frontend-vcapasenv-secret.yaml enterprise-app-clone-build-push-pipeline.yaml enterprise-app-git-event-triggerbinding.yaml enterprise-app-git-repo-eventlistener.yaml enterprise-app-image-registry-secret.yaml enterprise-app-ingress.yaml enterprise-app-tekton-triggers-admin-role.yaml enterprise-app-tekton-triggers-admin-rolebinding.yaml enterprise-app-tekton-triggers-admin-serviceaccount.yaml enterprise-app-clone-push-serviceaccount.yaml orders-vcapasenv-secret.yaml gateway-vcapasenv-secret.yaml]] 
ERRO[0001] Unable to parameterize /var/folders/81/pzmd85sj2d9dg02xgmd7wlhr0000gn/T/move2kube1886420936/environment-Parameterizer-2689628992/3778034170/base-parameterized/kustomize/base/kustomization.yaml : there is no kind specified in the k8s resource map[resources:[enterprise-app-run-clone-build-push-triggertemplate.yaml frontend-vcapasenv-secret.yaml enterprise-app-clone-build-push-pipeline.yaml enterprise-app-git-event-triggerbinding.yaml enterprise-app-git-repo-eventlistener.yaml enterprise-app-image-registry-secret.yaml enterprise-app-ingress.yaml enterprise-app-tekton-triggers-admin-role.yaml enterprise-app-tekton-triggers-admin-rolebinding.yaml enterprise-app-tekton-triggers-admin-serviceaccount.yaml enterprise-app-clone-push-serviceaccount.yaml orders-vcapasenv-secret.yaml gateway-vcapasenv-secret.yaml]] 

…terizer

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 14.84%. Comparing base (14357a9) to head (0d8d154).

Files Patch % Lines
...nsformer/kubernetes/parameterizer/parameterizer.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   14.91%   14.84%   -0.08%     
==========================================
  Files          90       90              
  Lines        8380     8367      -13     
==========================================
- Hits         1250     1242       -8     
+ Misses       6805     6802       -3     
+ Partials      325      323       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seshapad seshapad merged commit d049f65 into konveyor:main Mar 21, 2024
4 checks passed
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/getonlyk8syamls branch March 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants