fix: K8s version change transformer was not being run sometimes because Parameterizer was running first #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se Parameterizer was running first feat: Added a new feature to sort transformers based on a label "move2kube.konveyor.io/sort-order" specified in the transformer.yaml. This is only the initial sorted order in which transformers are run and does not affect dependency related stuff like MandatoryPassThrough. Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
|
Thanks for making a pull request! 😃 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 14.83% 14.79% -0.04%
==========================================
Files 90 90
Lines 8379 8401 +22
==========================================
Hits 1243 1243
- Misses 6813 6835 +22
Partials 323 323 ☔ View full report in Codecov by Sentry. |
ashokponkumar
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added a new feature to sort transformers based on a label
move2kube.konveyor.io/sort-orderspecified in thetransformer.yaml. This is only the initial sorted order in which transformers are run and does not affect dependency related stuff likeMandatoryPassThrough.