refactor: added the error to the log messages when processing path mappings #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request! 😃 |
…ppings Signed-off-by: Jeremy L. Morris <jmorris@digitalocean.com>
ashokponkumar
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the returned errors to the log message. It should help to clarify the somewhat ambiguous/identical log messages. It appears that there are multiple reasons for an error to occur. For example, the
processfunction which gets called when doing aTemplateCopycould error in multiple ways while processing a file, symlink or directory. The uniqueness of the possible errors can be valuable in situations where we'd need to debug using these log messages.