Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Maven Repo: Display spinner when fetching cache #990

Merged
merged 1 commit into from
Jun 7, 2023
Merged

✨ Maven Repo: Display spinner when fetching cache #990

merged 1 commit into from
Jun 7, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jun 7, 2023

@gildub gildub changed the title Maven Repo: Display spinner when fetching cache ✨ Maven Repo: Display spinner when fetching cache Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (32171cd) 47.31% compared to head (79bdac7) 47.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   47.31%   47.31%           
=======================================
  Files         177      177           
  Lines        4345     4345           
  Branches      978      978           
=======================================
  Hits         2056     2056           
  Misses       2276     2276           
  Partials       13       13           
Flag Coverage Δ
unitests 47.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gildub gildub self-assigned this Jun 7, 2023
@gildub gildub added the needs-backport Needs backport label Jun 7, 2023
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gildub gildub requested a review from mturley June 7, 2023 15:39
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
@gildub gildub merged commit 7dd6218 into konveyor:main Jun 7, 2023
@gildub gildub deleted the mta-470 branch June 7, 2023 16:09
gildub added a commit that referenced this pull request Jun 8, 2023
ibolton336 pushed a commit to ibolton336/tackle2-ui that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Needs backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants