Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translation] Fix English and French translations #1029

Merged
merged 8 commits into from
Dec 25, 2023
Merged

[translation] Fix English and French translations #1029

merged 8 commits into from
Dec 25, 2023

Conversation

hacketiwack
Copy link
Contributor

@hacketiwack hacketiwack commented Dec 24, 2023

Description

With this PR, I propose a lot of fixes for the English and French translations.
In my humble opinion, the reference to the strings in the translation files should not be the full english translations, but keys.
I would transform the translation files to a structured JSON files.

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

Copy link

netlify bot commented Dec 24, 2023

Deploy Preview for koodo-reader ready!

Name Link
🔨 Latest commit 74e734e
🔍 Latest deploy log https://app.netlify.com/sites/koodo-reader/deploys/65889845258e57000892b715
😎 Deploy Preview https://deploy-preview-1029--koodo-reader.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@troyeguo troyeguo merged commit 07557fa into koodo-reader:master Dec 25, 2023
4 checks passed
troyeguo added a commit that referenced this pull request Jan 25, 2024
[translation] Fix English and French translations
troyeguo added a commit that referenced this pull request Jan 25, 2024
[translation] Fix English and French translations
troyeguo added a commit that referenced this pull request Jan 25, 2024
[translation] Fix English and French translations

Former-commit-id: 5a9e3bf
troyeguo added a commit that referenced this pull request Mar 2, 2024
[translation] Fix English and French translations

Former-commit-id: 5a9e3bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants