Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker compilation failed #984

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Conversation

jectpro7
Copy link

@jectpro7 jectpro7 commented Nov 1, 2023

Description

Fix compilation error

Related Issues

  1. node 14 is not compatiable with node 18
  2. package python is not found in node18. install python3 instead
  3. react-script is missing during build. So run yarn to install dependencies before build

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for flourishing-kulfi-75011e ready!

Name Link
🔨 Latest commit a063cbf
🔍 Latest deploy log https://app.netlify.com/sites/flourishing-kulfi-75011e/deploys/6542981dda48e5000987a444
😎 Deploy Preview https://deploy-preview-984--flourishing-kulfi-75011e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jectpro7
Copy link
Author

jectpro7 commented Nov 1, 2023

Hi @troyeguo ,

koodo is a well known UI friendly reader tool. I am trying to deploy koodo in my private NAS for a better reading experience. But I faced some unexpected error during build docker image. I suggest to push a official docekr image to dockerHub for user to easily setup the docker container for their usecase.

@troyeguo troyeguo merged commit 7ddde03 into koodo-reader:master Nov 4, 2023
4 of 5 checks passed
@troyeguo
Copy link
Collaborator

troyeguo commented Nov 4, 2023

Hi @troyeguo ,

koodo is a well known UI friendly reader tool. I am trying to deploy koodo in my private NAS for a better reading experience. But I faced some unexpected error during build docker image. I suggest to push a official docekr image to dockerHub for user to easily setup the docker container for their usecase.

For now, only github and sourceforge is maintained by me personally. But any help from community are welcomed

troyeguo added a commit that referenced this pull request Jan 25, 2024
Fix docker compilation failed
troyeguo added a commit that referenced this pull request Jan 25, 2024
Fix docker compilation failed
troyeguo added a commit that referenced this pull request Jan 25, 2024
Fix docker compilation failed

Former-commit-id: ebdff0e
troyeguo added a commit that referenced this pull request Mar 2, 2024
Fix docker compilation failed

Former-commit-id: ebdff0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants