Prevent date fields from being add to response when not requested #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lready handled separately in FeatureServer when producing `fields` response parameter; but it occurs *after* the call to winnow and currently does not persist the array transformation to the options object.
…n the field name is one of the requested `outFields`.
trescube
reviewed
Apr 3, 2018
| function normalizeFields (options) { | ||
| const fields = options.fields || options.outFields | ||
| if (fields === '*') return undefined | ||
| return typeof fields === 'string' ? [fields] : fields | ||
| if (typeof fields === 'string' || fields instanceof String) return fields.split(',') |
There was a problem hiding this comment.
What's a scenario where fields would not be type string but also an instance of String? Is that some JS weirdness that can happen with prototypes?
There was a problem hiding this comment.
It's probably overkill here, but that can happen when a string is created with new String('Some text'), which has type Object. Check it out console.log(typeof new String("test")). So I usually default to string checking like this.
There was a problem hiding this comment.
Oh, Javascript, is there nothing you can't make confusing?
trescube
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that date fields were being add to response payloads even in cases where said date fields were excluded by use of the
outFieldsquery parameter. This caused unwanted drawing/rendering effects in ArcGIS Pro.Also discovered that
outFieldsarriving as a comma delimited string were not being parsed properly in Winnow queries.This PR includes a fix to parse the
outFieldsinput if comma-delimited, and additional checks to include date fields in response payloads only when specifically requested withoutFieldsquery param (or whenoutFields=*).