Fix / improve tile spatial filtering #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make tile spatial filtering work for PAM files, which should be spatial filtered based on the extent stored in the tile pointer file, not in the PAM pointer file. - Fixes a bug: the hash of the current spatial filter should be stored in the "workdir-state.db" sqlite DB, since it's more likely to reflect the true state of the workdir than the git config which is easy for the user to tamper with. Since this step was missing previously, spatial filtering worked poorly for tile-based datasets - Kart would forget it had already applied a spatial filter and would reapply it, and would fail to unapply a spatial filter in response to `kart checkout --spatial-filter=none`
craigds
approved these changes
May 3, 2023
into working_copy.py where they are common to both tabular and file-system working copies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make tile spatial filtering work for PAM files, which should be spatial filtered based on the extent stored in the tile pointer file, not in the PAM pointer file.
Fixes a bug: the hash of the current spatial filter should be stored in the "workdir-state.db" sqlite DB, since it's more likely to reflect the true state of the workdir than the git config which is easy for the user to tamper with. Since this step was missing previously, spatial filtering worked poorly for tile-based datasets - Kart would forget it had already applied a spatial filter and would reapply it, and would fail to unapply a spatial filter in response to
kart checkout --spatial-filter=noneHave you reviewed your own change?
Have you included test(s)?
Have you updated the changelog?