Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet:encapsulating reused logics(updatePodCFSQuota,updateContainerCFSQuota) #726

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

lucming
Copy link
Contributor

@lucming lucming commented Oct 20, 2022

Ⅰ. Describe what this PR does

  1. encapsulating reused logics
    eg: update CFSQuota of pod, update CFSQuota of Container
    this part of logic is used in many places,maybe better to encapsulated as a function
  2. reducing some logic nesting

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 66.89% // Head: 66.91% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e6d7e15) compared to base (df60f06).
Patch coverage: 84.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   66.89%   66.91%   +0.01%     
==========================================
  Files         234      234              
  Lines       26876    26873       -3     
==========================================
+ Hits        17978    17981       +3     
+ Misses       7620     7616       -4     
+ Partials     1278     1276       -2     
Flag Coverage Δ
unittests 66.91% <84.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/resmanager/cpu_burst.go 74.53% <84.21%> (+0.51%) ⬆️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@saintube
Copy link
Member

@lucming We are planning to refactor the cgroup updates in #720. It may change the implementation for updating pod/container cfs_quota. Could you please hold the encapsulation until the refactoring is done?

@lucming
Copy link
Contributor Author

lucming commented Oct 24, 2022

@lucming We are planning to refactor the cgroup updates in #720. It may change the implementation for updating pod/container cfs_quota. Could you please hold the encapsulation until the refactoring is done?

okay.

@jasonliu747
Copy link
Member

/hold

@saintube
Copy link
Member

/unhold
@lucming Hi, now it's okay to revise the updating of pod/container cfs_quota with the new ResourceExecutor module. Please feel free to continue this work at any time.

@lucming
Copy link
Contributor Author

lucming commented Dec 22, 2022

/unhold @lucming Hi, now it's okay to revise the updating of pod/container cfs_quota with the new ResourceExecutor module. Please feel free to continue this work at any time.

okay.

Signed-off-by: lucming <2876757716@qq.com>
@lucming lucming changed the title encapsulating reused logics(updatePodCFSQuota,updateContainerCFSQuota) koordlet:encapsulating reused logics(updatePodCFSQuota,updateContainerCFSQuota) Dec 22, 2022
@saintube
Copy link
Member

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 0a02d28 into koordinator-sh:main Dec 27, 2022
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
…rCFSQuota) (#726)

Signed-off-by: lucming <2876757716@qq.com>
lucming added a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
…rCFSQuota) (koordinator-sh#726)

Signed-off-by: lucming <2876757716@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants