-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet:encapsulating reused logics(updatePodCFSQuota,updateContainerCFSQuota) #726
Conversation
9acf4b3
to
53fd600
Compare
Codecov ReportBase: 66.89% // Head: 66.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
+ Coverage 66.89% 66.91% +0.01%
==========================================
Files 234 234
Lines 26876 26873 -3
==========================================
+ Hits 17978 17981 +3
+ Misses 7620 7616 -4
+ Partials 1278 1276 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/hold |
/unhold |
okay. |
53fd600
to
32b3b47
Compare
Signed-off-by: lucming <2876757716@qq.com>
32b3b47
to
e6d7e15
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rCFSQuota) (#726) Signed-off-by: lucming <2876757716@qq.com>
…rCFSQuota) (koordinator-sh#726) Signed-off-by: lucming <2876757716@qq.com>
Ⅰ. Describe what this PR does
eg: update CFSQuota of pod, update CFSQuota of Container
this part of logic is used in many places,maybe better to encapsulated as a function
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test