-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: proposal koordlet support cgroups v2 #720
docs: proposal koordlet support cgroups v2 #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, and we shouldn't change any code in a proposal PR.
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
62f129b
to
515cc3e
Compare
Codecov ReportBase: 68.15% // Head: 68.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
=======================================
Coverage 68.15% 68.15%
=======================================
Files 210 210
Lines 24102 24102
=======================================
Hits 16427 16427
- Misses 6535 6536 +1
+ Partials 1140 1139 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
OK. I will split this PR. |
515cc3e
to
e26f9c1
Compare
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
2c2005d
to
9fe457c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
/cc @stormgbs |
6819185
to
491df9b
Compare
docs/proposals/koordlet/20221018-koordlet-support-cgroups-v2.md
Outdated
Show resolved
Hide resolved
491df9b
to
cb791db
Compare
2929106
to
b2071b5
Compare
Signed-off-by: saintube <saintube@foxmail.com>
b2071b5
to
00e3c4d
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The `IsSupported()` method is defined for checking the compatibility of system resources when trying to modify the files. | ||
|
||
```go | ||
type ResourceType string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(FYI) I think ResourceName maybe a better choice :)
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Add a proposal that clarifies how to support cgroups v2 in the koordlet.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test