-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: refactor cgroup resource #834
koordlet: refactor cgroup resource #834
Conversation
4674131
to
73264df
Compare
Codecov ReportBase: 67.50% // Head: 67.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 67.50% 67.64% +0.14%
==========================================
Files 219 224 +5
Lines 24988 25561 +573
==========================================
+ Hits 16868 17291 +423
- Misses 6942 7069 +127
- Partials 1178 1201 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/lgtm |
73264df
to
09f98ff
Compare
a045fc4
to
b7bceca
Compare
/assign @FillZpp |
/approve |
Signed-off-by: saintube <saintube@foxmail.com>
b7bceca
to
f1841f6
Compare
/ping @zwzhang0107 @FillZpp |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.1 |
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Refactor the CgroupResource module. Implement
system.Resource
interface (proposed in #720 ) to support file operations on cgroups-v2.Ⅱ. Does this pull request fix one issue?
part of #407
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test