Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: refactor cgroup resource #834

Merged

Conversation

saintube
Copy link
Member

Signed-off-by: saintube saintube@foxmail.com

Ⅰ. Describe what this PR does

Refactor the CgroupResource module. Implement system.Resource interface (proposed in #720 ) to support file operations on cgroups-v2.

Ⅱ. Does this pull request fix one issue?

part of #407

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 67.50% // Head: 67.64% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (f1841f6) compared to base (e0e889f).
Patch coverage: 71.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   67.50%   67.64%   +0.14%     
==========================================
  Files         219      224       +5     
  Lines       24988    25561     +573     
==========================================
+ Hits        16868    17291     +423     
- Misses       6942     7069     +127     
- Partials     1178     1201      +23     
Flag Coverage Δ
unittests 67.64% <71.46%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/metriccache/storage_tables.go 57.14% <ø> (ø)
pkg/koordlet/metrics/common.go 68.96% <ø> (ø)
pkg/koordlet/metricsadvisor/collector.go 10.63% <0.00%> (-0.39%) ⬇️
.../koordlet/qosmanager/metricsquery/metrics_query.go 57.54% <ø> (ø)
pkg/util/system/resource.go 20.68% <20.68%> (ø)
pkg/koordlet/executor/types.go 31.48% <31.81%> (ø)
pkg/util/stat.go 64.28% <35.00%> (-16.80%) ⬇️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <60.00%> (+1.17%) ⬆️
...dlet/metricsadvisor/performance_collector_linux.go 69.56% <60.57%> (-7.97%) ⬇️
pkg/util/system/validator.go 64.70% <62.50%> (-35.30%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hormes
Copy link
Member

hormes commented Nov 24, 2022

/lgtm

pkg/util/system/cgroup.go Show resolved Hide resolved
pkg/util/system/resource.go Outdated Show resolved Hide resolved
pkg/util/system/cgroup_resource.go Outdated Show resolved Hide resolved
pkg/util/system/cgroup_resource.go Outdated Show resolved Hide resolved
pkg/util/system/cgroup_resource.go Show resolved Hide resolved
@koordinator-bot koordinator-bot bot removed the lgtm label Nov 25, 2022
@saintube saintube force-pushed the refactor-resource-executor branch 2 times, most recently from a045fc4 to b7bceca Compare November 28, 2022 03:40
@saintube saintube requested review from zwzhang0107 and removed request for FillZpp November 28, 2022 03:48
@zwzhang0107
Copy link
Contributor

/assign @FillZpp

@FillZpp
Copy link
Member

FillZpp commented Nov 29, 2022

/approve
/hold
Please fix the conflicts.

Signed-off-by: saintube <saintube@foxmail.com>
@saintube
Copy link
Member Author

saintube commented Nov 29, 2022

/ping @zwzhang0107 @FillZpp

@FillZpp
Copy link
Member

FillZpp commented Nov 29, 2022

/lgtm
/hold cancel

@zwzhang0107
Copy link
Contributor

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2a905d1 into koordinator-sh:main Nov 29, 2022
@FillZpp
Copy link
Member

FillZpp commented Dec 13, 2022

/milestone v1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants