Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix cpi collector return value sequence #909

Merged

Conversation

songtao98
Copy link
Contributor

Signed-off-by: songtao98 songtao2603060@gmail.com

Ⅰ. Describe what this PR does

Previously the cpi collector utils has a return value sequence bug, which reverses the sequence of cycles and instructions , leading that when compute CPI we actually get the reciprocal of it.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: songtao98 <songtao2603060@gmail.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 66.63% // Head: 66.64% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (93071e9) compared to base (0a02d28).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   66.63%   66.64%           
=======================================
  Files         238      238           
  Lines       27675    27682    +7     
=======================================
+ Hits        18442    18449    +7     
  Misses       7965     7965           
  Partials     1268     1268           
Flag Coverage Δ
unittests 66.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/util/perf/perf_linux.go 50.00% <100.00%> (ø)
pkg/scheduler/plugins/reservation/rcache.go 89.16% <0.00%> (+0.09%) ⬆️
pkg/scheduler/plugins/reservation/hook.go 79.16% <0.00%> (+0.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koordinator-bot koordinator-bot bot merged commit 580b447 into koordinator-sh:main Dec 29, 2022
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: songtao98 <songtao2603060@gmail.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Signed-off-by: songtao98 <songtao2603060@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants