-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: add metrics for batch resources #913
koordlet: add metrics for batch resources #913
Conversation
bde8f37
to
a9c3281
Compare
Very cool ! Finally, we have the BE-pods metrics. @saintube |
Codecov ReportBase: 66.56% // Head: 66.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 66.56% 66.64% +0.08%
==========================================
Files 240 241 +1
Lines 27754 27858 +104
==========================================
+ Hits 18474 18567 +93
- Misses 8009 8015 +6
- Partials 1271 1276 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b4f21a7
to
a879b43
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤏
a879b43
to
801b9a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: saintube <saintube@foxmail.com>
801b9a1
to
817962a
Compare
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube saintube@foxmail.com
Ⅰ. Describe what this PR does
Add Prometheus metrics for node's and pod's batch resources, including metrics below:
Fix some spelling errors.
Fix metrics
koordlet_node_used_cpu_cores
andkoordlet_be_suppress_ls_used_cpu_cores
, and use cores instead of milli-cores as the unit.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test