koord-descheduler: refactor descheduler pod sorter #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahydra
requested review from
hormes,
FillZpp,
ZiMengSheng,
saintube,
jasonliu747 and
zwzhang0107
3 tasks
Codecov ReportBase: 66.44% // Head: 66.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 66.44% 66.57% +0.12%
==========================================
Files 241 243 +2
Lines 27925 28043 +118
==========================================
+ Hits 18556 18670 +114
+ Misses 8092 8091 -1
- Partials 1277 1282 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eahydra
force-pushed
the
refactor_descheduler_pod_sorter_v1
branch
from
fdeaaa1
to
87985ee
Compare
jasonliu747
reviewed
Jan 9, 2023
pkg/descheduler/framework/plugins/loadaware/utilization_util.go
Outdated
Show resolved
Hide resolved
eahydra
force-pushed
the
refactor_descheduler_pod_sorter_v1
branch
from
87985ee
to
ade680b
Compare
eahydra
force-pushed
the
refactor_descheduler_pod_sorter_v1
branch
from
ade680b
to
6a572fd
Compare
eahydra
force-pushed
the
refactor_descheduler_pod_sorter_v1
branch
from
6a572fd
to
b1e4269
Compare
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
eahydra
force-pushed
the
refactor_descheduler_pod_sorter_v1
branch
from
b1e4269
to
8abb697
Compare
|
updated to resolve conflicts |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FillZpp
pushed a commit
that referenced
this pull request
Jan 16, 2023
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
lucming
pushed a commit
to lucming/koordinator
that referenced
this pull request
Feb 8, 2023
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joseph joseph.t.lee@outlook.com
Ⅰ. Describe what this PR does
refactor koord-descheduler pod sorter:
V. Checklist
make test