Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-descheduler: support pod deletion cost and eviction cost #939

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Jan 7, 2023

Signed-off-by: Joseph joseph.t.lee@outlook.com

Ⅰ. Describe what this PR does

  1. Migration Controller supports filtered Pod that has max eviction cost.
  2. PodSorter supports pod deletion cost and eviction cost.

Ⅱ. Does this pull request fix one issue?

fix #938

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra eahydra changed the title koord-descheduler: support Pod deletion cost and eviction cost koord-descheduler: support pod deletion cost and eviction cost Jan 7, 2023
@eahydra
Copy link
Member Author

eahydra commented Jan 7, 2023

/hold
should merge #937 first

@eahydra eahydra force-pushed the support_deletion_eviction_cost_in_descheduler branch from c2641bd to d6c0034 Compare January 7, 2023 11:03
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Base: 66.56% // Head: 66.62% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (b29b021) compared to base (4ba54c6).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   66.56%   66.62%   +0.06%     
==========================================
  Files         243      243              
  Lines       28064    28090      +26     
==========================================
+ Hits        18680    18715      +35     
+ Misses       8099     8093       -6     
+ Partials     1285     1282       -3     
Flag Coverage Δ
unittests 66.62% <88.88%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/descheduler/controllers/migration/controller.go 62.06% <0.00%> (-0.09%) ⬇️
pkg/descheduler/utils/sorter/pod.go 88.88% <95.45%> (+5.77%) ⬆️
pkg/descheduler/controllers/migration/util/util.go 73.21% <100.00%> (+1.51%) ⬆️
pkg/util/httputil/reverseproxy.go 85.10% <0.00%> (+0.79%) ⬆️
pkg/koordlet/runtimehooks/reconciler/reconciler.go 67.05% <0.00%> (+1.17%) ⬆️
pkg/descheduler/utils/sorter/helper.go 79.24% <0.00%> (+5.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra removed the request for review from a team January 9, 2023 03:13
@eahydra eahydra force-pushed the support_deletion_eviction_cost_in_descheduler branch from d6c0034 to c0a3182 Compare January 9, 2023 03:36
@jasonliu747
Copy link
Member

/unhold
@eahydra 937 was merged, please fix the conflicts.

@eahydra eahydra force-pushed the support_deletion_eviction_cost_in_descheduler branch from c0a3182 to 29da4f4 Compare January 10, 2023 03:55
@koordinator-bot koordinator-bot bot added size/L and removed size/XL labels Jan 10, 2023
@eahydra eahydra force-pushed the support_deletion_eviction_cost_in_descheduler branch from 29da4f4 to 8366f6e Compare January 10, 2023 03:56
@eahydra
Copy link
Member Author

eahydra commented Jan 10, 2023

updated to resolve conflicts

apis/extension/descheduling.go Outdated Show resolved Hide resolved
apis/extension/descheduling.go Show resolved Hide resolved
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
@eahydra eahydra force-pushed the support_deletion_eviction_cost_in_descheduler branch from 8366f6e to b29b021 Compare January 10, 2023 07:48
Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit d656bd0 into koordinator-sh:main Jan 10, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: Joseph <joseph.t.lee@outlook.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] should support eviction cost in descheduler
3 participants