-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-scheduler: optimize ElasticQuota QuotaInfo present methods #951
koord-scheduler: optimize ElasticQuota QuotaInfo present methods #951
Conversation
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
Codecov ReportBase: 66.42% // Head: 66.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
==========================================
+ Coverage 66.42% 66.98% +0.55%
==========================================
Files 241 243 +2
Lines 27908 28184 +276
==========================================
+ Hits 18539 18878 +339
+ Misses 8092 8016 -76
- Partials 1277 1290 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
…rdinator-sh#951) Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
Signed-off-by: kingeasternsun kingeasternsun@gmail.com
Ⅰ. Describe what this PR does
addPodIfNotPresent
, this function should return early if pod present.removePodIfPresent
, this function should return early if pod not present.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test