Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-scheduler: optimize ElasticQuota QuotaInfo present methods #951

Merged

Conversation

kingeasternsun
Copy link
Contributor

Signed-off-by: kingeasternsun kingeasternsun@gmail.com

Ⅰ. Describe what this PR does

  • From the name of function addPodIfNotPresent, this function should return early if pod present.
  • From the name of function removePodIfPresent, this function should return early if pod not present.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 66.42% // Head: 66.98% // Increases project coverage by +0.55% 🎉

Coverage data is based on head (97326af) compared to base (3b88616).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   66.42%   66.98%   +0.55%     
==========================================
  Files         241      243       +2     
  Lines       27908    28184     +276     
==========================================
+ Hits        18539    18878     +339     
+ Misses       8092     8016      -76     
- Partials     1277     1290      +13     
Flag Coverage Δ
unittests 66.98% <50.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../scheduler/plugins/elasticquota/core/quota_info.go 82.88% <50.00%> (-0.26%) ⬇️
pkg/descheduler/controllers/migration/util/util.go 65.07% <0.00%> (-6.62%) ⬇️
pkg/scheduler/plugins/coscheduling/core/core.go 36.84% <0.00%> (-2.89%) ⬇️
pkg/scheduler/plugins/reservation/hook.go 77.00% <0.00%> (-2.17%) ⬇️
...dlet/statesinformer/states_noderesourcetopology.go 63.76% <0.00%> (-0.79%) ⬇️
pkg/scheduler/plugins/reservation/plugin.go 80.43% <0.00%> (-0.40%) ⬇️
pkg/descheduler/evictions/evictions.go 90.81% <0.00%> (-0.28%) ⬇️
pkg/scheduler/plugins/coscheduling/coscheduling.go 70.09% <0.00%> (-0.01%) ⬇️
pkg/util/pod_resources_utils.go 52.87% <0.00%> (ø)
...runtimehooks/hooks/batchresource/batch_resource.go 69.91% <0.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eahydra eahydra changed the title koord-scheduler: (quota_info) fix logic of If Present or not koord-scheduler: optimize ElasticQuota QuotaInfo present methods Jan 12, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 2fcd601 into koordinator-sh:main Jan 12, 2023
FillZpp pushed a commit that referenced this pull request Jan 16, 2023
Signed-off-by: kingeasternsun <kingeasternsun@gmail.com>
lucming pushed a commit to lucming/koordinator that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants