This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Fix build on case-insensitive file systems (MacOS) #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hakman |
|
Fix for the cloudbuild failure is (hopefully) in #363 |
|
Nice. Thanks! :) |
Due to bazelbuild/rules_go#456 , the build of etcd 2.2.1 did not work correctly on case-insensitive file systems, including MacOS. etcd has a shell script named `build`, which bazel was treating as a `BUILD` file. By setting bazel to only look for `BUILD.bazel` files, this is avoided.
justinsb
force-pushed
the
support-mac-build
branch
from
ca3f928
to
95aa7df
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bazelbuild/rules_go#456 , the build of etcd 2.2.1 did not work correctly on case-insensitive file systems, including MacOS.
etcd has a shell script named
build, which bazel was treating as aBUILDfile. By setting bazel to only look forBUILD.bazelfiles, this is avoided.