Added directory breadcrumb buttons to see path and navigate back #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- be able to view the current path one came to the current directory - be able to quickly navigate upwards
ptandler
changed the title
|
I took a quick look, the idea is great, but we need to work on layout: I suggest using links via React Breadcrumbs component: https://react-bootstrap.github.io/components/breadcrumb/ |
|
Thanks you for your feedback, as soon as I have some spare time, I'll give this a try. WRT the OID, I agree that it is distracting in most cases, but I'd like to have it in a way that I could copy it if required (e.g. for some CLI actions). Maybe this works with a tooltip. |
- no tooltip if no OID - disable / improve wrapping of tooltip - disable clicking on current breadcrumb item
|
@jkowalski I now had time to do the changes you suggested. What do you think?
|
|
This is very cool, can you rebase to latest main and we can merge... |
# Conflicts: # src/App.css # src/uiutil.jsx
|
@jkowalski merged main |
jkowalski
added a commit
to jkowalski/kopia
that referenced
this pull request
Sep 5, 2023
jkowalski
added a commit
to kopia/kopia
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added directory breadcrumbs to
Before, you need to click
Returnseveral times - and you could not see the path.Please note, this is the first time I'm using React, so I'd be glad if someone could have a look and check if this is the way to go.