-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added directory breadcrumb buttons to see path and navigate back #141
Conversation
- be able to view the current path one came to the current directory - be able to quickly navigate upwards
I took a quick look, the idea is great, but we need to work on layout: I suggest using links via React Breadcrumbs component: https://react-bootstrap.github.io/components/breadcrumb/ |
Thanks you for your feedback, as soon as I have some spare time, I'll give this a try. WRT the OID, I agree that it is distracting in most cases, but I'd like to have it in a way that I could copy it if required (e.g. for some CLI actions). Maybe this works with a tooltip. |
- no tooltip if no OID - disable / improve wrapping of tooltip - disable clicking on current breadcrumb item
@jkowalski I now had time to do the changes you suggested. What do you think? |
This is very cool, can you rebase to latest main and we can merge... |
# Conflicts: # src/App.css # src/uiutil.jsx
@jkowalski merged main |
Added directory breadcrumbs to
Before, you need to click
Return
several times - and you could not see the path.Please note, this is the first time I'm using React, so I'd be glad if someone could have a look and check if this is the way to go.