-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing compression #166
Comments
you need to set policy on What kinds of files are you compressing? Many files these days are not really compressible at all. To verify the compression do |
It's ok with setting policy on the source. I've tried with kopia source and it's ok also. But i found that with a sql dump as text, very compressible (153M possibly gziped to 10M) there is an issue.
Without compression
With compression
I cleared cache and create new repository each time edit: also mem usage is going very high (800M) |
Weird, I'll investigate this - I downloaded a 163MB SQL dump from https://launchpad.net/test-db/+download and I can also see this. |
this effectively defeated the purpose of compression, caused high memory usage and other kinds of bad behavior. refactored the code to prevent this issue by resetting the buffer at the caller not callee. fixed previous e2e test to catch the issue mentioned in #166, verified it fails against master and passes with this change.
I can confirm that it fix the issue \o/. You've done it very rapidly. I will test it now with my home on a daily basis to compare with real data. Thanks ! |
btw you can see which compression algo is the fastest with:
|
Changing the algo, it's a lot faster with s2. Still a little bit slower than borg (lz4) but, for me, i don't think it need to be investigated more than that. |
this effectively defeated the purpose of compression, caused high memory usage and other kinds of bad behavior. refactored the code to prevent this issue by resetting the buffer at the caller not callee. fixed previous e2e test to catch the issue mentioned in #166, verified it fails against master and passes with this change.
I'm trying to test compression but i don't see any compression.
The repository has exactly the same size without setting compression (580M for 617M of source, 259M with targz).
Did I missed some configuration ?
I also tried setting compression with --global
edit: I build kopia with today clone
The text was updated successfully, but these errors were encountered: