feat(snapshots): added support for reading from named pipes #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3034 +/- ##
==========================================
- Coverage 75.52% 75.52% -0.01%
==========================================
Files 460 460
Lines 36641 36646 +5
==========================================
+ Hits 27674 27677 +3
Misses 7050 7050
- Partials 1917 1919 +2
☔ View full report in Codecov by Sentry. |
acul009
changed the title
jkowalski
reviewed
Aug 5, 2023
fs/localfs/local_fs.go
Outdated
| @@ -356,6 +356,7 @@ func Directory(path string) (fs.Directory, error) { | |||
| func entryFromDirEntry(fi os.FileInfo, prefix string) fs.Entry { | |||
| isplaceholder := strings.HasSuffix(fi.Name(), ShallowEntrySuffix) | |||
| maskedmode := fi.Mode() & os.ModeType | |||
| readNamedEnv := os.Getenv("KOPIA_SNAPSHOT_NAMED_PIPES") | |||
There was a problem hiding this comment.
this function is called in a tight loop, reading from environment has non-trivial cost and should be avoided in such a place.
There was a problem hiding this comment.
Thanks for reviewing :)
I‘ll update the PR to cache the value.
There was a problem hiding this comment.
I moved the variable outside the function. This should fix the performance issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is just 2 lines, which makes kopia read named pipes like files. I'd like to use that for streaming multiple database dumps in the same snapshot, so the backup is atomic.