refactor(general): add epoch.Manager.MaybeAdvanceEpoch helper #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
force-pushed
the
feat/maybe-advance-epoch
branch
from
5261d99
to
2844f78
Compare
julio-lopez
commented
Mar 7, 2024
internal/epoch/epoch_manager_test.go
Outdated
| @@ -529,6 +529,74 @@ func TestSlowWrite_MovesToNextEpochTwice(t *testing.T) { | |||
| require.Contains(t, err.Error(), "slow index write") | |||
| } | |||
|
|
|||
| func TestMabyeAdvanceEpochEmpty(t *testing.T) { | |||
There was a problem hiding this comment.
Tests not originally in #3651
| @@ -723,6 +723,25 @@ func (e *Manager) refreshAttemptLocked(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // MaybeAdvanceWriteEpoch writes a new write epoch marker when a new write | |||
| // epoch should be started, otherwise it does not do anything. | |||
| func (e *Manager) MaybeAdvanceWriteEpoch(ctx context.Context) error { | |||
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3709 +/- ##
==========================================
+ Coverage 75.86% 77.03% +1.16%
==========================================
Files 470 476 +6
Lines 37301 28753 -8548
==========================================
- Hits 28299 22150 -6149
+ Misses 7071 4675 -2396
+ Partials 1931 1928 -3 ☔ View full report in Codecov by Sentry. |
julio-lopez
force-pushed
the
feat/maybe-advance-epoch
branch
from
2844f78
to
ecccceb
Compare
julio-lopez
force-pushed
the
feat/maybe-advance-epoch
branch
from
ecccceb
to
67844e6
Compare
6 tasks
julio-lopez
added a commit
that referenced
this pull request
Mar 27, 2024
…3651) Perform index epoch compaction and cleanup during repository maintenance * refactor: rename maintenance task for deleting superseded indexes * maintenance task to cleanup epoch markers * maintenance task to advance write index epoch * maintenance task to compact epoch ranges * quick maintenance task to compact a single (index) epoch * full maintenance task to compact a single (index) epoch Ref: - #3638 - #3639 Followup to: - #3603 - #3645 Related helpers and changes: - #3721 - #3735 - #3709 - #3728 - #3727 - #3726
Lyndon-Li
pushed a commit
to Lyndon-Li/kopia
that referenced
this pull request
Mar 29, 2024
…opia#3651) Perform index epoch compaction and cleanup during repository maintenance * refactor: rename maintenance task for deleting superseded indexes * maintenance task to cleanup epoch markers * maintenance task to advance write index epoch * maintenance task to compact epoch ranges * quick maintenance task to compact a single (index) epoch * full maintenance task to compact a single (index) epoch Ref: - kopia#3638 - kopia#3639 Followup to: - kopia#3603 - kopia#3645 Related helpers and changes: - kopia#3721 - kopia#3735 - kopia#3709 - kopia#3728 - kopia#3727 - kopia#3726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
epoch.Manager.MaybeAdvanceEpoch helperand tests.The helper is not yet invoked in maintenance, a separate change
will add all the epoch management cleanup tasks to maintenance.
Ref: