Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-specific file directory should show user name #572

Open
koppor opened this issue May 30, 2022 · 14 comments · Fixed by #658
Open

user-specific file directory should show user name #572

koppor opened this issue May 30, 2022 · 14 comments · Fixed by #658

Comments

@koppor
Copy link
Owner

koppor commented May 30, 2022

image

It is unclear, which JabRef key is used there.

*Update

  • Show tooltip of username and host when hovering on "User-specific file directory" and the text box next to it
  • Also add a tooltip to LaTeX file directory
@koppor
Copy link
Owner Author

koppor commented Jun 13, 2022

Proposal: A however on the label "user-specific file directory" should show the username.

@jackmcardle99
Copy link

Hi @koppor , Soft Eng intern here. I'd like to take a stab at this issue if it's possible. Thanks.

@koppor
Copy link
Owner Author

koppor commented Jun 6, 2023

@jackmcardle99 I assigned you. Should be three lines of code.

@koppor
Copy link
Owner Author

koppor commented Jun 8, 2023

When reading JabRef#9990, there should also be a proper tool tip on "LaTeX file directory". Maybe you can work on that too @jackmcardle99?

@jackmcardle99
Copy link

Will get started on both issues this weekend @koppor

@JoleneSun111
Copy link

JoleneSun111 commented Oct 11, 2023

Hello, I'm a new contributor, and I will carefully read the contribution guidelines. Could you please assign this issue to me? @ThiloteE
U6591996
W-10

@ThiloteE
Copy link
Collaborator

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@JoleneSun111
Copy link

In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?

Username: This is the unique identifier of the user within the system. For instance, in the Windows operating system, the username could be "john_doe," while in the Linux operating system, it might be "jane_smith."

User's Home Directory: This is the main folder in the file system associated with the user, usually identified by their username. For instance, in the Windows operating system, the main directory might be "C:\Users\john_doe," whereas in the Linux operating system, it could be "/home/jane_smith."

Which of these should JabRef use to identify the user when they are not logged in? @koppor @ThiloteE Thank you so much for your help.

@JoleneSun111
Copy link

JoleneSun111 commented Oct 21, 2023

I do my change in Display_username branch, before my pull request, just wanna check if my change satisfy the issue's requirement:
Now the username is displayed:
image

I do several changes in the org.jabref.gui.libraryproperties.general.
src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java:
image
org/jabref/gui/libraryproperties/general/GeneralProperties.fxml
image
src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesViewModel.java
image

@koppor @ThiloteE

@JoleneSun111
Copy link

In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?

Username: This is the unique identifier of the user within the system. For instance, in the Windows operating system, the username could be "john_doe," while in the Linux operating system, it might be "jane_smith."

User's Home Directory: This is the main folder in the file system associated with the user, usually identified by their username. For instance, in the Windows operating system, the main directory might be "C:\Users\john_doe," whereas in the Linux operating system, it could be "/home/jane_smith."

Which of these should JabRef use to identify the user when they are not logged in? @koppor @ThiloteE Thank you so much for your help.

image

@koppor
Copy link
Owner Author

koppor commented Oct 21, 2023

In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?

JabRef already handles this. It uses the log in user name of the current user. As you outlined, this is different from the laptop / PC / workstation / ... one uses.

The shown graphics looks like a debug version.

Please implement as follows:

Implement a hover on user-specific file directory. If the mouse is on hower, JabRef displays: user: {username}, host: {hostname}.

Please DO NOT modify the field content. This is the place, where the user configures their directory.

@JoleneSun111
Copy link

JoleneSun111 commented Oct 22, 2023

589e2a9a049ace9deb4f7ab3096b275

This is the presentation of this pull request. I am still confused about the log in user, because even though I have read the documentation, I still cannot find where to log in JabRef.

In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?

JabRef already handles this. It uses the log in user name of the current user. As you outlined, this is different from the laptop / PC / workstation / ... one uses.

The shown graphics looks like a debug version.

Please implement as follows:

Implement a hover on user-specific file directory. If the mouse is on hower, JabRef displays: user: {username}, host: {hostname}.

Please DO NOT modify the field content. This is the place, where the user configures their directory.

@koppor @ThiloteE

@calixtus
Copy link
Collaborator

You cannot log in to JabRef, since JabRef is not a multi-user distributed application, but just a desktop application for the current os user to use. But multiple users are working with JabRef, every user has probably his own home directory.
It is also not of importance, what username JabRef should use, if no user is logged in, because no user could use JabRef, when not logged in to a computer running JabRef.
Still I don't get your question.

Please don't use the issue description to present screenshots of your code changes, but put this all into your Pull Request, since this clutters the issue discription with a lot of information that is about your PR and not about the original issue.

@calixtus calixtus reopened this Oct 22, 2023
@calixtus
Copy link
Collaborator

There went sthg wrong, when i tried to resolve merge conflicts with in a PR, sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants