Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tag propagation for Repository codegen #81

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mitasov-ra
Copy link
Contributor

@mitasov-ra mitasov-ra commented Jul 11, 2024

I noticed that it's impossible to put tags on @Repository interfaces:

@Repository
@Tag(MyRepo::class) // Impl won't have this Tag
interface MyRepo : JdbcRepository

The only current workaround for this issue:

interface MyRepoModule {
  @Tag(MyRepo::class)
  fun myRepo(factory: JdbcConnectionFactory) = `\$MyRepo_Impl`(factory)
}

I think this is unnecessary complication, so in this PR I adding @Tag propagation from @Repository marked interface/abstract class to it's generated Impl

@Squiry Squiry merged commit 440390f into kora-projects:master Aug 5, 2024
8 checks passed
@GoodforGod GoodforGod added this to the v1.1.7 milestone Aug 6, 2024
@GoodforGod GoodforGod added the minor Minor improvement to existing features label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor improvement to existing features module: database Related to databases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants