Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Not" Scan Type Feature #257

Merged
merged 5 commits into from
May 12, 2024
Merged

"Not" Scan Type Feature #257

merged 5 commits into from
May 12, 2024

Conversation

OpenNetSurfer
Copy link
Contributor

  • A new option in scan type comboBox is added
  • tr.py is updated to include string Not
  • Option works only with INT and FLOAT value type

@OpenNetSurfer
Added "Not" option as a scan type
9a31ccf 
Cannot work with AOB or STRING value type. Working on disabling "Not" when those are selected
@OpenNetSurfer
Added fully functional "Not" Scan Type!
59bbe65
@OpenNetSurfer
Merge branch 'korcankaraokcu:master' into master
72d6e6d
brkzlr
brkzlr requested changes May 12, 2024
View reviewed changes
PINCE.py Outdated Show resolved Hide resolved
PINCE.py Outdated Show resolved Hide resolved
brkzlr
brkzlr approved these changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@brkzlr brkzlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine so far.

One thing to note is to please refrain from committing stuff with "(Ignore)" in title and such in the future. No commit should be ignored.

I'll let Korcan take a look/test as well before we merge this.

@brkzlr brkzlr linked an issue May 12, 2024 that may be closed by this pull request
Feature Request: Not option when "exact scanning" #253
Closed
@korcankaraokcu korcankaraokcu merged commit cb3537d into korcankaraokcu:master May 12, 2024
@korcankaraokcu
Copy link
Owner

Thanks for the patch!

@OpenNetSurfer
Copy link
Contributor Author

One thing to note is to please refrain from committing stuff with "(Ignore)" in title and such in the future. No commit should be ignored.

I understand. Will not do that in future

And I am glad I could contribute!

brkzlr pushed a commit to brkzlr/PINCE that referenced this pull request Sep 21, 2024
@OpenNetSurfer @brkzlr
"Not" Scan Type Feature (korcankaraokcu#257)
862576e 
* Added "Not" option as a scan type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korcankaraokcu korcankaraokcu korcankaraokcu approved these changes

@brkzlr brkzlr brkzlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Not option when "exact scanning"
3 participants
@OpenNetSurfer @korcankaraokcu @brkzlr