-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update permission type #544
Update permission type #544
Conversation
Why is |
Because of the Unknown class; in case Discord provided a permission that the user know but we don't |
There is no Unknown class here, it would also be more difficult to use then an Unknown class for some sort of type. |
It should have an unknown class; in case we encounter a permission we don't know |
I think we had a compiler bug with enums so we decided to use this approach |
Should I add a |
the unknown class won't be in the set anyways; it's unknown but it may provide the user with insight given that we hold the full permission set so they can interact with them. |
I don't mean |
I added a |
ManageEmojis
toManageEmojisAndStickers
(renamed in commit discord/discord-api-docs@db5a0cc of PR Document sticker packs, sticker routes, and guild stickers discord/discord-api-docs#3128)UseSlashCommands
toUseApplicationCommands
(renamed in commit discord/discord-api-docs@a6ca5e9 of PR User and Message Application Commands discord/discord-api-docs#3614)UseExternalStickers
(added in commit discord/discord-api-docs@03626e1 of PR Document sticker packs, sticker routes, and guild stickers discord/discord-api-docs#3128)UseEmbeddedActivities
(renamed in rename START_EMBEDDED_ACTIVITIES to USE_EMBEDDED_ACTIVITIES discord/discord-api-docs#4555)Stream
missing inPermission.values
I recommend a commit-wise review.