Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #920

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Update dependencies #920

merged 4 commits into from
Mar 4, 2024

Conversation

lukellmann
Copy link
Member

@lukellmann lukellmann commented Mar 2, 2024

* Gradle 8.5 -> 8.6
* Kotlin 1.9.21 -> 1.9.22
* Ktor 2.3.7 -> 2.3.8
* kotlinx.coroutines 1.7.3 -> 1.8.0
* kotlinx.serialization 1.6.2 -> 1.6.3
* kotlin-logging 6.0.1 -> 6.0.3
* SLF4J 2.0.9 -> 2.0.12
* kotlin-node 18.16.12-pre.619 -> 20.11.5-pre.706
* kotlin-multiplatform-bignum 0.3.8 -> 0.3.9
* KSP 1.9.21-1.0.16 -> 1.9.22-1.0.17
* KotlinPoet 1.15.3 -> 1.16.0
* JUnit 5 5.10.1 -> 5.10.2
* MockK 1.13.8 -> 1.13.10
* AtomicFU 0.23.1 -> 0.23.2
* Binary compatibility validator 0.13.2 -> 0.14.0
* gradle-buildconfig-plugin 5.1.0 -> 5.3.5
* Foojay Toolchains Plugin 0.7.0 -> 0.8.0
* gradle/wrapper-validation-action v1 -> v2
* Replace gradle/gradle-build-action with gradle/actions/setup-gradle
@lukellmann
Copy link
Member Author

I get this compiler error when trying to access node.process.process. Any idea how to fix this @DRSchlaubi?

e: file:///... When accessing module declarations from UMD, they must be marked by both @JsModule and @JsNonModule

@DRSchlaubi
Copy link
Member

Downgrading kotlin-node usually helps

@lukellmann
Copy link
Member Author

Downgrading kotlin-node usually helps

hm, but i don't want to never update this dependency

@lukellmann
Copy link
Member Author

i've opened an issue, let's see what the response to that is: JetBrains/kotlin-wrappers#2221

@lukellmann
Copy link
Member Author

i've opened an issue, let's see what the response to that is: JetBrains/kotlin-wrappers#2221

the solution is to change the target JS module system from UMD to CommonJS / ES modules: 5bcc68e (see JetBrains/kotlin-wrappers#2221). i've chosen CommonJS as that's supported for all Node.js versions afaik, ES modules were supported at some later point.

this also allows us to remove @JsNonModule from JsInflater.kt.

@lukellmann lukellmann merged commit 5f9294c into main Mar 4, 2024
8 of 9 checks passed
@lukellmann lukellmann deleted the dependencies branch March 4, 2024 18:21
@lukellmann lukellmann removed the request for review from DRSchlaubi March 4, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants